Skip to content

Avoid cloning constants when compiling hints #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2025
Merged

Avoid cloning constants when compiling hints #2208

merged 3 commits into from
Nov 13, 2025
+24 −24

Conversation

@JulianGCalderon
Copy link
Contributor

@JulianGCalderon JulianGCalderon commented Sep 25, 2025

Avoid cloning constants when compiling hints

Description

By changing the compile_hint parameter type to Arc instead of Rc, we can reuse the constants that are already included in Program. This avoids cloning all the constants.

This PR is breaking, as the constants parameter of compile_hints was changed from Rc to Arc. This allows to reuse the already extracted constants, and not have to clone it.

@JulianGCalderon
Avoid cloning constants when compiling hints
f6ef4c1 
By changing the compile_hint parameter type to `Arc` instead of `Rc`, we
can reuse the constants that are already included in `Program`. This
avoids cloning all the constants.

With this commit, there is a 9.8% performance increase when replaying
mainnet block 10000, compared to 2.5.0.
@JulianGCalderon
Update CHANGELOG.md
3ac66b8
@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading 

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     22.876 s ±  0.051 s    [User: 22.002 s, System: 0.871 s]
  Range (min … max):   22.840 s … 22.912 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     22.813 s ±  0.000 s    [User: 21.935 s, System: 0.875 s]
  Range (min … max):   22.813 s … 22.813 s    2 runs
 
Summary
  hyper_threading_pr threads: 1 ran
    1.00 ± 0.00 times faster than hyper_threading_main threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     12.244 s ±  0.008 s    [User: 21.986 s, System: 0.906 s]
  Range (min … max):   12.238 s … 12.249 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     12.309 s ±  0.051 s    [User: 22.138 s, System: 0.904 s]
  Range (min … max):   12.273 s … 12.345 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.01 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):      9.481 s ±  0.041 s    [User: 34.080 s, System: 1.100 s]
  Range (min … max):    9.451 s …  9.510 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):      9.752 s ±  0.007 s    [User: 34.253 s, System: 1.069 s]
  Range (min … max):    9.747 s …  9.757 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.03 ± 0.00 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):      9.536 s ±  0.376 s    [User: 34.530 s, System: 1.097 s]
  Range (min … max):    9.271 s …  9.802 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):      9.618 s ±  0.151 s    [User: 34.356 s, System: 1.124 s]
  Range (min … max):    9.511 s …  9.725 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.424 s ±  0.105 s    [User: 34.886 s, System: 1.115 s]
  Range (min … max):    9.350 s …  9.498 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):      9.377 s ±  0.091 s    [User: 34.827 s, System: 1.067 s]
  Range (min … max):    9.313 s …  9.441 s    2 runs
 
Summary
  hyper_threading_pr threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_main threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):      9.360 s ±  0.067 s    [User: 35.091 s, System: 1.209 s]
  Range (min … max):    9.312 s …  9.408 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):      9.549 s ±  0.163 s    [User: 34.953 s, System: 1.189 s]
  Range (min … max):    9.434 s …  9.664 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.02 ± 0.02 times faster than hyper_threading_pr threads: 16

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 1.931 ± 0.009 1.915 1.947 1.00
head big_factorial 1.939 ± 0.016 1.925 1.981 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 1.877 ± 0.011 1.862 1.894 1.00
head big_fibonacci 1.881 ± 0.014 1.863 1.909 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 6.682 ± 0.097 6.555 6.805 1.01 ± 0.02
head blake2s_integration_benchmark 6.603 ± 0.076 6.554 6.790 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 1.993 ± 0.014 1.971 2.009 1.00
head compare_arrays_200000 2.012 ± 0.018 1.990 2.043 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.339 ± 0.005 1.332 1.348 1.00
head dict_integration_benchmark 1.355 ± 0.057 1.325 1.516 1.01 ± 0.04
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.131 ± 0.009 1.120 1.144 1.00
head field_arithmetic_get_square_benchmark 1.133 ± 0.007 1.123 1.146 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 6.761 ± 0.081 6.677 6.877 1.01 ± 0.02
head integration_builtins 6.706 ± 0.075 6.641 6.869 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 6.765 ± 0.076 6.681 6.875 1.01 ± 0.01
head keccak_integration_benchmark 6.727 ± 0.065 6.648 6.833 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 1.976 ± 0.018 1.958 2.008 1.00
head linear_search 1.981 ± 0.010 1.970 2.000 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.439 ± 0.012 1.425 1.464 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 1.421 ± 0.007 1.410 1.431 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.392 ± 0.011 1.382 1.417 1.02 ± 0.01
head math_integration_benchmark 1.367 ± 0.007 1.360 1.378 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.130 ± 0.010 1.122 1.156 1.00 ± 0.01
head memory_integration_benchmark 1.125 ± 0.005 1.118 1.134 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.462 ± 0.005 1.454 1.472 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.458 ± 0.009 1.444 1.471 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 508.1 ± 1.2 507.0 511.1 1.00 ± 0.00
head pedersen 507.0 ± 1.8 504.7 511.0 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 595.3 ± 1.5 592.7 597.3 1.00 ± 0.01
head poseidon_integration_benchmark 592.5 ± 2.8 589.3 599.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.733 ± 0.012 1.719 1.756 1.00 ± 0.01
head secp_integration_benchmark 1.725 ± 0.011 1.713 1.744 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 647.1 ± 0.9 645.7 648.3 1.07 ± 0.00
head set_integration_benchmark 605.2 ± 1.3 603.5 606.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 3.868 ± 0.051 3.814 3.978 1.01 ± 0.01
head uint256_integration_benchmark 3.824 ± 0.025 3.791 3.875 1.00

@codecov
Copy link

codecov bot commented Sep 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (f0022cd) to head (763b4cc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2208   +/-   ##
=======================================
  Coverage   95.98%   95.98%           
=======================================
  Files         104      104           
  Lines       36794    36794           
=======================================
  Hits        35315    35315           
  Misses       1479     1479

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JulianGCalderon JulianGCalderon marked this pull request as ready for review September 25, 2025 17:29
DiegoCivi
DiegoCivi approved these changes Nov 13, 2025
View reviewed changes
Copy link
Contributor

@DiegoCivi DiegoCivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gabrielbosio gabrielbosio added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main with commit 9cedff9 Nov 13, 2025
94 checks passed
@gabrielbosio gabrielbosio deleted the opt-vm-3 branch November 13, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielbosio gabrielbosio gabrielbosio approved these changes

@DiegoCivi DiegoCivi DiegoCivi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JulianGCalderon @gabrielbosio @DiegoCivi